Issue 644763005: Change the ServiceWorker scope in the Push Messaging tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 644763005: Change the ServiceWorker scope in the Push Messaging tests. (Closed)

Created:
6 years, 1 month ago by horo

Modified:
6 years, 1 month ago

Reviewers:
falken

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Change the ServiceWorker scope in the Push Messaging tests. The registrations of the ServiceWorker scope outside the script directory will be restricted, as per discussion on https://github.com/slightlyoff/ServiceWorker/issues/468. So this cl changes the scope which is used in PushMessaging tests. After this patch will land, I will re-intoruce the scope restriction in Blink side by reverting this: https://codereview.chromium.org/672353003/ BUG=423983 Committed: https://crrev.com/e89207403f8451b197d0aeed1003c63b0b266823 Cr-Commit-Position: refs/heads/master@{#301312}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/data/push_messaging/test.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644763005/1

6 years, 1 month ago (2014-10-27 03:09:00 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-10-27 03:52:13 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e89207403f8451b197d0aeed1003c63b0b266823
Cr-Commit-Position: refs/heads/master@{#301312}