Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1793)

Issue 64453002: Refactor loading a pointer into a register instruction for X64 (Closed)

Created:
7 years, 1 month ago by haitao.feng
Modified:
6 years, 11 months ago
Reviewers:
danno, Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Refactor loading a pointer into a register instruction for X64 R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18479

Patch Set 1 #

Patch Set 2 : Rebased with bleeding_edge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -70 lines) Patch
M src/x64/assembler-x64.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 3 chunks +6 lines, -25 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 chunks +19 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 16 chunks +25 lines, -25 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
haitao.feng
I use Move macro instruction to deal with a data whose size is kPointerSize. The ...
7 years, 1 month ago (2013-11-07 13:54:35 UTC) #1
haitao.feng
Rebased with ToT. PTAL. I will upload a CL to replace movq with movp at ...
7 years ago (2013-12-03 05:47:40 UTC) #2
Toon Verwaest
LGTM. The use of NONE64 is a bit odd given that Move (movp) will move ...
7 years ago (2013-12-04 09:52:56 UTC) #3
haitao.feng
On 2013/12/04 09:52:56, Toon Verwaest wrote: > LGTM. The use of NONE64 is a bit ...
7 years ago (2013-12-04 12:12:51 UTC) #4
haitao.feng
6 years, 11 months ago (2014-01-08 07:02:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r18479 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698