src/x64/stub-cache-x64.cc - Issue 64453002: Refactor loading a pointer into a register instruction for X64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/stub-cache-x64.cc

Issue 64453002: Refactor loading a pointer into a register instruction for X64 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Rebased with bleeding_edge Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/stub-cache-x64.cc

diff --git a/src/x64/stub-cache-x64.cc b/src/x64/stub-cache-x64.cc

index 9bf6e9f2fb34d2ec94d52a3067d33092ff7a2995..5f8164577f74e516b4de5cc5d7cc3077c1f97933 100644

--- a/src/x64/stub-cache-x64.cc

+++ b/src/x64/stub-cache-x64.cc

@@ -1308,7 +1308,7 @@ Register LoadStubCompiler::CallbackHandlerFrontend(

__ movq(scratch2(),

Operand(dictionary, index, times_pointer_size,

kValueOffset - kHeapObjectTag));

- __ movq(scratch3(), callback, RelocInfo::EMBEDDED_OBJECT);

+ __ Move(scratch3(), callback, RelocInfo::EMBEDDED_OBJECT);

__ cmpq(scratch2(), scratch3());

__ j(not_equal, &miss);

}

@@ -2668,7 +2668,7 @@ Handle<Code> KeyedStoreStubCompiler::CompileStorePolymorphic(

} else {

Label next_map;

__ j(not_equal, &next_map, Label::kNear);

- __ movq(transition_map(),

+ __ Move(transition_map(),

transitioned_maps->at(i),

RelocInfo::EMBEDDED_OBJECT);

__ jmp(handler_stubs->at(i), RelocInfo::CODE_TARGET);

« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | test/cctest/test-macro-assembler-x64.cc » ('j') | no next file with comments »