Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: Source/bindings/core/v8/V8Binding.cpp

Issue 644473006: Rename 'ScalarValueString' to 'USVString' to match Web IDL (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/V8BindingTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8Binding.cpp
diff --git a/Source/bindings/core/v8/V8Binding.cpp b/Source/bindings/core/v8/V8Binding.cpp
index 4fe108f2d1554a3c87e451323b8f8c55370f62b8..106ed695522f52adf4426243a6ddccc3e54884cc 100644
--- a/Source/bindings/core/v8/V8Binding.cpp
+++ b/Source/bindings/core/v8/V8Binding.cpp
@@ -665,10 +665,9 @@ static String replaceUnmatchedSurrogates(const String& string)
return u.toString();
}
-String toScalarValueString(v8::Handle<v8::Value> value, ExceptionState& exceptionState)
+String toUSVString(v8::Handle<v8::Value> value, ExceptionState& exceptionState)
{
- // From the Encoding standard (with a TODO to move to Web IDL):
- // http://encoding.spec.whatwg.org/#type-scalarvaluestring
+ // http://heycam.github.io/webidl/#es-USVString
if (value.IsEmpty())
return String();
@@ -679,7 +678,7 @@ String toScalarValueString(v8::Handle<v8::Value> value, ExceptionState& exceptio
return String();
}
- // ScalarValueString is identical to DOMString except that "convert a
+ // USVString is identical to DOMString except that "convert a
// DOMString to a sequence of Unicode characters" is used subsequently
// when converting to an IDL value
String x = toCoreString(stringObject);
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/V8BindingTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698