Source/bindings/core/v8/V8BindingTest.cpp - Issue 644473006: Rename 'ScalarValueString' to 'USVString' to match Web IDL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8BindingTest.cpp

Issue 644473006: Rename 'ScalarValueString' to 'USVString' to match Web IDL (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8BindingTest.cpp

diff --git a/Source/bindings/core/v8/V8BindingTest.cpp b/Source/bindings/core/v8/V8BindingTest.cpp

index 52662bc702cf5615f1b2a11d219b18794bf9bcf4..ad913d877870e079f8255bcb7d08ec379ae33bcf 100644

--- a/Source/bindings/core/v8/V8BindingTest.cpp

+++ b/Source/bindings/core/v8/V8BindingTest.cpp

@@ -348,7 +348,7 @@ TEST_F(V8ValueTraitsTest, toImplArray)

NonThrowableExceptionState exceptionState;

Vector<v8::Handle<v8::Value> > v8HandleVector = toImplArray<v8::Handle<v8::Value> >(v8Array, 0, m_scope.isolate(), exceptionState);

EXPECT_EQ(3U, v8HandleVector.size());

- EXPECT_EQ("Vini, vidi, vici.", toScalarValueString(v8HandleVector[0], exceptionState));

+ EXPECT_EQ("Vini, vidi, vici.", toUSVString(v8HandleVector[0], exceptionState));

EXPECT_EQ(65535U, toUInt32(v8HandleVector[1]));

EXPECT_EQ(0.125, toFloat(v8HandleVector[2]));

« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | Source/bindings/scripts/idl_types.py » ('j') | no next file with comments »