Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 644473006: Rename 'ScalarValueString' to 'USVString' to match Web IDL (Closed)

Created:
6 years, 2 months ago by jsbell
Modified:
6 years, 2 months ago
Reviewers:
haraken, sof, bashi
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, arv+blink, tzik, sof, eae+blinkwatch, nhiroki, falken, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, horo+watch_chromium.org, kinuko+serviceworker, rwlbuis, bashi (use chromium)
Project:
blink
Visibility:
Public.

Description

Rename 'ScalarValueString' to 'USVString' to match Web IDL Originally proposed in the Encoding standard as 'ScalarValueString', this type was finally added to Web IDL with the name 'USVString' ("Unicode scalar value string"). The behavior is identical: unpaired UTF-16 surrogate code units in JS strings are converted to U+FFFD replacement characters by the binding layer. The type name is not exposed to script, so this is not a web-exposed change. Spec: http://heycam.github.io/webidl/#idl-USVString BUG=423660 R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -230 lines) Patch
M LayoutTests/fast/encoding/api/utf16-surrogates-encode.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/js/webidl-type-mapping.html View 2 chunks +25 lines, -25 lines 0 comments Download
M LayoutTests/fast/js/webidl-type-mapping-expected.txt View 1 chunk +53 lines, -53 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/V8BindingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/idl_types.py View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/bindings/scripts/v8_interface.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_types.py View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/idls/core/TestInterfaceConstructor4.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/core/TestObject.idl View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 10 chunks +56 lines, -56 lines 0 comments Download
M Source/core/dom/URL.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/URLUtils.idl View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/core/dom/URLUtilsReadOnly.idl View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/core/testing/TypeConversions.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/testing/TypeConversions.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/modules/encoding/TextEncoder.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/Cache.idl View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/modules/serviceworkers/CacheStorage.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/RegistrationOptions.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/Request.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/RequestInit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/Response.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerRegistration.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
jsbell
haraken@ - PTAL? Purely mechanical rename of 'ScalarValueString' -> 'USVString' and 'scalarValueString' -> 'usvString', plus ...
6 years, 2 months ago (2014-10-23 18:55:31 UTC) #1
sof
lgtm
6 years, 2 months ago (2014-10-23 21:52:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644473006/1
6 years, 2 months ago (2014-10-23 22:54:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/18222)
6 years, 2 months ago (2014-10-23 23:07:47 UTC) #7
jsbell
On 2014/10/23 23:07:47, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-23 23:17:44 UTC) #8
haraken
LGTM
6 years, 2 months ago (2014-10-23 23:29:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644473006/1
6 years, 2 months ago (2014-10-23 23:32:53 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 23:39:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184312

Powered by Google App Engine
This is Rietveld 408576698