Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 644473005: ServiceManagement test: reduce test flake (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

ServiceManagement test: reduce test flake. ExpectProcessIsRunning() goes to a lot of trouble to deal with the flaky {CTL_KERN, KERN_PROCARGS2} API exposed by ProcessArgumentsForPID(). It retries that call inside an inner loop until it succeeds, because it may fail while a process is mid-exec(). Once it succeeds, it should use the argv it obtained. Waiting for success and then attempting to call ProcessArgumentsForPID() again to get argv can be flaky when the first attempt succeeds because it’s pre-exec(), and the second one catches the process in the middle of the exec() and fails. The existence of the inner loop was intended to protect against this problem, and the subsequent call outside of the inner loop appears to be left behind from before the inner loop existed. It should have been removed when the inner loop was added. TEST=util_test ServiceManagement.SubmitRemoveJob R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/7669b3301048b71aa1f405d34b020847c6efb950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M util/mac/service_management_test.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 2 months ago (2014-10-09 19:54:12 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-09 21:14:16 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-09 21:26:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7669b3301048b71aa1f405d34b020847c6efb950 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698