util/mac/service_management_test.mm - Issue 644473005: ServiceManagement test: reduce test flake

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/mac/service_management_test.mm

Issue 644473005: ServiceManagement test: reduce test flake (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/mac/service_management_test.mm

diff --git a/util/mac/service_management_test.mm b/util/mac/service_management_test.mm

index 278272165113a8bb8731c0fdf7b460e3a52ab4c6..e1f76f73169ad7780559fedb247de38f3bdcce48 100644

--- a/util/mac/service_management_test.mm

+++ b/util/mac/service_management_test.mm

@@ -58,7 +58,6 @@ void ExpectProcessIsRunning(pid_t pid, std::string& last_arg) {

} while (inner_tries--);

ASSERT_TRUE(success);

- ASSERT_TRUE(ProcessArgumentsForPID(pid, &job_argv));

ASSERT_FALSE(job_argv.empty());

if (job_argv.back() == last_arg) {

break;

« no previous file with comments | « no previous file | no next file » | no next file with comments »