Replace MockStatisticsProvider with FakeStatisticsProvider.

Replace MockStatisticsProvider with FakeStatisticsProvider.

MockStatisticsProvider is a typical example of gmock only causing
excess boilerplate and poor readability. This change implements a
proper fake and converts all consumers.

BUG=None
TEST=unit_tests/browser_tests still compile and pass.

Committed: https://crrev.com/6e01d07c5ca1a2b711ca494d2320dbe4423e4ee8
Cr-Commit-Position: refs/heads/master@{#299350}

[Mattias Nissler (ping if slow), 2014-10-13 13:51:00]

mnissler@chromium.org changed reviewers:
+ asargent@chromium.org, stevenjb@chromium.org

[Mattias Nissler (ping if slow), 2014-10-13 13:51:00]

stevenjb: Main reviewer
asargent: chrome/browser/extensions/OWNERS

[stevenjb, 2014-10-13 14:28:20]

https://codereview.chromium.org/644413003/diff/1/chrome/browser/chromeos/cust...
File chrome/browser/chromeos/customization_document_unittest.cc (right):

https://codereview.chromium.org/644413003/diff/1/chrome/browser/chromeos/cust...
chrome/browser/chromeos/customization_document_unittest.cc:139:
EXPECT_EQ("mozc-jp", customization.keyboard_layout());
We don't appear to test 'hardware_class' or 'keyboard_layout'; we should
probably either not set those, test them, or add a comment wrt why they need to
be set.

https://codereview.chromium.org/644413003/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/external_provider_impl_unittest.cc (right):

https://codereview.chromium.org/644413003/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/external_provider_impl_unittest.cc:146:
chromeos::system::ScopedFakeStatisticsProvider fake_statistics_provider_;
Is this used somewhere?

[Mattias Nissler (ping if slow), 2014-10-13 15:01:08]

PTAL

https://codereview.chromium.org/644413003/diff/1/chrome/browser/chromeos/cust...
File chrome/browser/chromeos/customization_document_unittest.cc (right):

https://codereview.chromium.org/644413003/diff/1/chrome/browser/chromeos/cust...
chrome/browser/chromeos/customization_document_unittest.cc:139:
EXPECT_EQ("mozc-jp", customization.keyboard_layout());
On 2014/10/13 14:28:20, stevenjb wrote:
> We don't appear to test 'hardware_class' or 'keyboard_layout'; we should
> probably either not set those, test them, or add a comment wrt why they need
to
> be set.

Added comment for hardware_class. keyboard_layout is tested in line 139.

https://codereview.chromium.org/644413003/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/external_provider_impl_unittest.cc (right):

https://codereview.chromium.org/644413003/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/external_provider_impl_unittest.cc:146:
chromeos::system::ScopedFakeStatisticsProvider fake_statistics_provider_;
On 2014/10/13 14:28:20, stevenjb wrote:
> Is this used somewhere?

Yes, added a clarifying comment.

[stevenjb, 2014-10-13 15:07:43]

lgtm

https://codereview.chromium.org/644413003/diff/1/chrome/browser/extensions/ex...
File chrome/browser/extensions/external_provider_impl_unittest.cc (right):

https://codereview.chromium.org/644413003/diff/1/chrome/browser/extensions/ex...
chrome/browser/extensions/external_provider_impl_unittest.cc:146:
chromeos::system::ScopedFakeStatisticsProvider fake_statistics_provider_;
On 2014/10/13 15:01:08, Mattias Nissler wrote:
> On 2014/10/13 14:28:20, stevenjb wrote:
> > Is this used somewhere?
> 
> Yes, added a clarifying comment.

Ah, right, I forgot that ScopedFakeStatisticsProvider registers itself globally.
This might be a little more clear as a scoped_ptr<> with explicit
initializiation in the constructor, but arguably that's implicit in the name of
the class, so I'm fine with it as-is.

[Mattias Nissler (ping if slow), 2014-10-13 15:15:13]

The CQ bit was checked by mnissler@chromium.org

[commit-bot: I haz the power, 2014-10-13 15:16:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/644413003/260001

[commit-bot: I haz the power, 2014-10-13 15:22:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 15:22:33]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mattias Nissler (ping if slow), 2014-10-13 15:40:33]

Ah, still need Antony's stamp.

[asargent_no_longer_on_chrome, 2014-10-13 17:52:49]

lgtm

[Mattias Nissler (ping if slow), 2014-10-13 19:47:48]

The CQ bit was checked by mnissler@chromium.org

[commit-bot: I haz the power, 2014-10-13 19:48:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/644413003/260001

[commit-bot: I haz the power, 2014-10-13 19:52:42]

Committed patchset #2 (id:260001)

[commit-bot: I haz the power, 2014-10-13 19:53:29]

Patchset 2 (id:??) landed as
https://crrev.com/6e01d07c5ca1a2b711ca494d2320dbe4423e4ee8
Cr-Commit-Position: refs/heads/master@{#299350}