Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1832)

Unified Diff: chrome/browser/extensions/external_provider_impl_unittest.cc

Issue 644413003: Replace MockStatisticsProvider with FakeStatisticsProvider. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add clarifying comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc ('k') | chromeos/chromeos.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/external_provider_impl_unittest.cc
diff --git a/chrome/browser/extensions/external_provider_impl_unittest.cc b/chrome/browser/extensions/external_provider_impl_unittest.cc
index 20d0260f080951394a01c237149f6fe70e49235c..a4a257d496429541f3de208b5a8ce248f9be4e1a 100644
--- a/chrome/browser/extensions/external_provider_impl_unittest.cc
+++ b/chrome/browser/extensions/external_provider_impl_unittest.cc
@@ -33,13 +33,13 @@
#include "chrome/browser/chromeos/customization_document.h"
#include "chrome/browser/chromeos/login/users/fake_user_manager.h"
#include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
-#include "chromeos/system/mock_statistics_provider.h"
+#include "chromeos/system/fake_statistics_provider.h"
#include "chromeos/system/statistics_provider.h"
#endif
-using ::testing::_;
using ::testing::NotNull;
using ::testing::Return;
+using ::testing::_;
namespace extensions {
@@ -99,19 +99,10 @@ class ExternalProviderImplTest : public ExtensionServiceTestBase {
CommandLine* cmdline = CommandLine::ForCurrentProcess();
cmdline->AppendSwitchASCII(switches::kAppsGalleryUpdateURL,
test_server_->GetURL(kManifestPath).spec());
-#if defined(OS_CHROMEOS)
- chromeos::system::StatisticsProvider::SetTestProvider(
- &mock_statistics_provider_);
- EXPECT_CALL(mock_statistics_provider_, GetMachineStatistic(_, NotNull()))
- .WillRepeatedly(Return(false));
-#endif
}
virtual void TearDown() override {
-#if defined(OS_CHROMEOS)
- chromeos::system::StatisticsProvider::SetTestProvider(NULL);
TestingBrowserProcess::GetGlobal()->SetLocalState(NULL);
-#endif
}
private:
@@ -151,8 +142,11 @@ class ExternalProviderImplTest : public ExtensionServiceTestBase {
scoped_ptr<EmbeddedTestServer> test_server_;
scoped_ptr<ExtensionCacheFake> test_extension_cache_;
+
#if defined(OS_CHROMEOS)
- chromeos::system::MockStatisticsProvider mock_statistics_provider_;
+ // chromeos::ServicesCustomizationExternalLoader is hooked up as an
+ // extensions::ExternalLoader and depends on a functioning StatisticsProvider.
+ chromeos::system::ScopedFakeStatisticsProvider fake_statistics_provider_;
TestingPrefServiceSimple local_state_;
#endif
« no previous file with comments | « chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc ('k') | chromeos/chromeos.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698