Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 644073003: Fixing crash with sig: blink::FrameConsole::addMessage (Closed)

Created:
6 years, 2 months ago by kozyatinskiy1
Modified:
6 years, 2 months ago
Reviewers:
vsevik
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fixing crash with sig: blink::FrameConsole::addMessage R=vsevik@chromium.org BUG=424479 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M Source/core/frame/FrameConsole.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameConsole.cpp View 3 chunks +15 lines, -6 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kozyatinskiy1
Vsevolod, PTAL
6 years, 2 months ago (2014-10-23 12:39:05 UTC) #1
vsevik
lgtm
6 years, 2 months ago (2014-10-23 13:08:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644073003/1
6 years, 2 months ago (2014-10-23 13:09:06 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 14:30:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184270

Powered by Google App Engine
This is Rietveld 408576698