Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Side by Side Diff: Source/core/frame/FrameConsole.h

Issue 644073003: Fixing crash with sig: blink::FrameConsole::addMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/frame/FrameConsole.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 void addMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>); 58 void addMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>);
59 void adoptWorkerMessagesAfterTermination(WorkerGlobalScopeProxy*); 59 void adoptWorkerMessagesAfterTermination(WorkerGlobalScopeProxy*);
60 60
61 void reportResourceResponseReceived(DocumentLoader*, unsigned long requestId entifier, const ResourceResponse&); 61 void reportResourceResponseReceived(DocumentLoader*, unsigned long requestId entifier, const ResourceResponse&);
62 62
63 static String formatStackTraceString(const String& originalMessage, PassRefP trWillBeRawPtr<ScriptCallStack>); 63 static String formatStackTraceString(const String& originalMessage, PassRefP trWillBeRawPtr<ScriptCallStack>);
64 64
65 static void mute(); 65 static void mute();
66 static void unmute(); 66 static void unmute();
67 67
68 ConsoleMessageStorage* messageStorage();
69 void clearMessages(); 68 void clearMessages();
70 69
71 void didFailLoading(unsigned long requestIdentifier, const ResourceError&); 70 void didFailLoading(unsigned long requestIdentifier, const ResourceError&);
72 71
73 void trace(Visitor*); 72 void trace(Visitor*);
74 73
75 private: 74 private:
76 explicit FrameConsole(LocalFrame&); 75 explicit FrameConsole(LocalFrame&);
77 76
78 LocalFrame& frame() const 77 LocalFrame& frame() const
79 { 78 {
80 ASSERT(m_frame); 79 ASSERT(m_frame);
81 return *m_frame; 80 return *m_frame;
82 } 81 }
83 82
83 ConsoleMessageStorage* messageStorage();
84
84 RawPtrWillBeMember<LocalFrame> m_frame; 85 RawPtrWillBeMember<LocalFrame> m_frame;
85 OwnPtrWillBeMember<ConsoleMessageStorage> m_consoleMessageStorage;
86 }; 86 };
87 87
88 } // namespace blink 88 } // namespace blink
89 89
90 #endif // FrameConsole_h 90 #endif // FrameConsole_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/frame/FrameConsole.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698