Chromium Code Reviews Chromium Code Reviews
Issue 644073002:
Avoid layout when list color changes (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/fast/layout/list-color-change-no-layout.html |
| diff --git a/LayoutTests/fast/layout/list-color-change-no-layout.html b/LayoutTests/fast/layout/list-color-change-no-layout.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..2f214196178ff68426eaec7f9979db3578796c19 |
| --- /dev/null |
| +++ b/LayoutTests/fast/layout/list-color-change-no-layout.html |
| @@ -0,0 +1,17 @@ |
| +<!DOCTYPE html> |
|
mstensho (USE GERRIT)
2014/10/14 19:51:39
Sorry, one more thing: why is the test in fast/lay
Xianzhu
2014/10/14 20:38:41
fast/lists seems better. Moved.
|
| +<script src="../../resources/js-test.js"></script> |
| +<script> |
| +onload = function() { |
| + document.body.offsetTop; |
|
mstensho (USE GERRIT)
2014/10/14 19:06:03
Indentation is normally 4 spaces.
Xianzhu
2014/10/14 19:33:59
We allow both 2 and 4 space indentation for layout
mstensho (USE GERRIT)
2014/10/14 19:51:39
I stand corrected. :) I used to get issues raised
|
| + var target = document.getElementById('target'); |
| + target.style.color = 'green'; |
| + if (window.internals) { |
| + shouldBe("window.internals.updateStyleAndReturnAffectedElementCount()", "2", true); |
|
mstensho (USE GERRIT)
2014/10/14 19:06:03
Why quiet == true?
Xianzhu
2014/10/14 19:33:59
Because this is not what the test wants to test, b
mstensho (USE GERRIT)
2014/10/14 19:51:39
I don't see why it's necessary to hide it, though.
|
| + shouldBe("internals.needsLayoutCount()", "0"); |
| + } |
| +} |
| +</script> |
| +Should not layout when list color changes. |
| +<ul id="target"> |
| + <li>UL that causes layout to trigger</li> |
|
mstensho (USE GERRIT)
2014/10/14 19:06:03
Seems to me that this text is incorrect, after you
Xianzhu
2014/10/14 19:33:59
Done.
|
| +</ul> |
