LayoutTests/fast/layout/list-color-change-no-layout.html - Issue 644073002: Avoid layout when list color changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/layout/list-color-change-no-layout.html

Issue 644073002: Avoid layout when list color changes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	mstensho (USE GERRIT) 2014/10/14 19:51:39 Sorry, one more thing: why is the test in fast/lay Sorry, one more thing: why is the test in fast/layout/ when there's a fast/lists/ ? Xianzhu 2014/10/14 20:38:41 fast/lists seems better. Moved. Show quoted text On 2014/10/14 19:51:39, mstensho wrote: > Sorry, one more thing: why is the test in fast/layout/ when there's a > fast/lists/ ? fast/lists seems better. Moved.
	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 onload = function() {

	5 document.body.offsetTop;
	mstensho (USE GERRIT) 2014/10/14 19:06:03 Indentation is normally 4 spaces. Indentation is normally 4 spaces. Xianzhu 2014/10/14 19:33:59 We allow both 2 and 4 space indentation for layout Show quoted text On 2014/10/14 19:06:03, mstensho wrote: > Indentation is normally 4 spaces. We allow both 2 and 4 space indentation for layout tests (http://dev.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-I...). It seems that new tests tend to use 2. mstensho (USE GERRIT) 2014/10/14 19:51:39 I stand corrected. :) I used to get issues raised Show quoted text On 2014/10/14 19:33:59, Xianzhu wrote: > On 2014/10/14 19:06:03, mstensho wrote: > > Indentation is normally 4 spaces. > > We allow both 2 and 4 space indentation for layout tests > (http://dev.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-I...). > It seems that new tests tend to use 2. I stand corrected. :) I used to get issues raised on me back in the days when I used 2 spaces myself. But maybe the coding standard has changed in that regard since.
	6 var target = document.getElementById('target');

	7 target.style.color = 'green';

	8 if (window.internals) {

	9 shouldBe("window.internals.updateStyleAndReturnAffectedElementCount()", "2", true);
	mstensho (USE GERRIT) 2014/10/14 19:06:03 Why quiet == true? Why quiet == true? Xianzhu 2014/10/14 19:33:59 Because this is not what the test wants to test, b Show quoted text On 2014/10/14 19:06:03, mstensho wrote: > Why quiet == true? Because this is not what the test wants to test, but just a pre-requisition. mstensho (USE GERRIT) 2014/10/14 19:51:39 I don't see why it's necessary to hide it, though. Show quoted text On 2014/10/14 19:33:59, Xianzhu wrote: > On 2014/10/14 19:06:03, mstensho wrote: > > Why quiet == true? > > Because this is not what the test wants to test, but just a pre-requisition. I don't see why it's necessary to hide it, though. But no big deal.
	10 shouldBe("internals.needsLayoutCount()", "0");

	11 }

	12 }

	13 </script>

	14 Should not layout when list color changes.

	15 <ul id="target">

	16 <li>UL that causes layout to trigger</li>
	mstensho (USE GERRIT) 2014/10/14 19:06:03 Seems to me that this text is incorrect, after you Seems to me that this text is incorrect, after your fix. Xianzhu 2014/10/14 19:33:59 Done. Show quoted text On 2014/10/14 19:06:03, mstensho wrote: > Seems to me that this text is incorrect, after your fix. Done.
	17 </ul>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/layout/list-color-change-no-layout-expected.txt » ('j') | Source/core/rendering/RenderListItem.cpp » ('J')