Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 643903005: Swapped the variable names "WebView" and "WebViewInternal" in web_view.js and other files that impo… (Closed)

Created:
6 years, 2 months ago by paulmeyer
Modified:
6 years, 2 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Swapped the variable names "WebView" and "WebViewInternal" in web_view.js and other files that import them. These variables were inconsistenly named (compared to other variables), leading to confusing lines like: var WebViewInternal = require('webView').WebViewInternal; var WebView = require('webViewInternal').WebView; This completes lazyboy@'s TODO in web_view.js. Committed: https://crrev.com/c1303d0370de45b3fe0ab3f977be575f275e2f86 Cr-Commit-Position: refs/heads/master@{#300117}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -108 lines) Patch
M chrome/renderer/resources/extensions/chrome_web_view.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/chrome_web_view_experimental.js View 1 3 chunks +7 lines, -8 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view.js View 1 28 chunks +72 lines, -73 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_events.js View 13 chunks +15 lines, -15 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_experimental.js View 2 chunks +8 lines, -8 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_internal.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
paulmeyer
+lazyboy@
6 years, 2 months ago (2014-10-16 16:36:39 UTC) #2
lazyboy
LGTM with nits. https://chromiumcodereview.appspot.com/643903005/diff/1/chrome/renderer/resources/extensions/chrome_web_view_experimental.js File chrome/renderer/resources/extensions/chrome_web_view_experimental.js (right): https://chromiumcodereview.appspot.com/643903005/diff/1/chrome/renderer/resources/extensions/chrome_web_view_experimental.js#newcode18 chrome/renderer/resources/extensions/chrome_web_view_experimental.js:18: var ChromeWebViewSchema = btw, can you ...
6 years, 2 months ago (2014-10-17 00:28:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643903005/20001
6 years, 2 months ago (2014-10-17 15:30:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/69666)
6 years, 2 months ago (2014-10-17 16:02:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643903005/20001
6 years, 2 months ago (2014-10-17 16:44:34 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-17 16:46:43 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 16:48:26 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c1303d0370de45b3fe0ab3f977be575f275e2f86
Cr-Commit-Position: refs/heads/master@{#300117}

Powered by Google App Engine
This is Rietveld 408576698