Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3567)

Unified Diff: extensions/renderer/resources/guest_view/web_view_experimental.js

Issue 643903005: Swapped the variable names "WebView" and "WebViewInternal" in web_view.js and other files that impo… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/guest_view/web_view_experimental.js
diff --git a/extensions/renderer/resources/guest_view/web_view_experimental.js b/extensions/renderer/resources/guest_view/web_view_experimental.js
index 7d1ffe128c29ae20d0e2deee6b74bc2fcbaf1ad7..93e117d766eb7d6289f3021b0dc5cea54fa2ec58 100644
--- a/extensions/renderer/resources/guest_view/web_view_experimental.js
+++ b/extensions/renderer/resources/guest_view/web_view_experimental.js
@@ -8,31 +8,31 @@
// <webview> Experimental API is only available on canary and dev channels of
// Chrome.
-var WebViewInternal = require('webView').WebViewInternal;
-var WebView = require('webViewInternal').WebView;
+var WebView = require('webView').WebView;
+var WebViewInternal = require('webViewInternal').WebViewInternal;
// Returns a map of experimental <webview> DOM event names to their associated
// extension event descriptor objects. See |WEB_VIEW_EVENTS| in
// web_view_events.js for more information and details on how this map should
// be formatted.
-WebViewInternal.prototype.maybeGetExperimentalEvents = function() {
+WebView.prototype.maybeGetExperimentalEvents = function() {
return {};
};
// Captures the visible content within the webview.
-WebViewInternal.prototype.captureVisibleRegion = function(spec, callback) {
- WebView.captureVisibleRegion(this.guestInstanceId, spec, callback);
+WebView.prototype.captureVisibleRegion = function(spec, callback) {
+ WebViewInternal.captureVisibleRegion(this.guestInstanceId, spec, callback);
};
// Loads a data URL with a specified base URL used for relative links.
// Optionally, a virtual URL can be provided to be shown to the user instead
// of the data URL.
-WebViewInternal.prototype.loadDataWithBaseUrl = function(
+WebView.prototype.loadDataWithBaseUrl = function(
dataUrl, baseUrl, virtualUrl) {
if (!this.guestInstanceId) {
return;
}
- WebView.loadDataWithBaseUrl(
+ WebViewInternal.loadDataWithBaseUrl(
this.guestInstanceId, dataUrl, baseUrl, virtualUrl, function() {
// Report any errors.
if (chrome.runtime.lastError != undefined) {
@@ -44,7 +44,7 @@ WebViewInternal.prototype.loadDataWithBaseUrl = function(
};
// Registers the experimantal WebVIew API when available.
-WebViewInternal.maybeGetExperimentalAPIs = function() {
+WebView.maybeGetExperimentalAPIs = function() {
var experimentalMethods = [
'captureVisibleRegion',
'loadDataWithBaseUrl'

Powered by Google App Engine
This is Rietveld 408576698