Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 643893003: Don't create a BrowserAccessibilityManager for a child frame on Android. (Closed)

Created:
6 years, 2 months ago by dmazzoni
Modified:
6 years, 2 months ago
CC:
chromium-reviews, clholgat, darin-cc_chromium.org, jam, nona+watch_chromium.org, penghuang+watch_chromium.org, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dmazzoni_testing
Project:
chromium
Visibility:
Public.

Description

Don't create a BrowserAccessibilityManager for a child frame on Android. A better fix will be needed for cross-process iframes support, but for now this is safe and solves the bug. BUG=423846 Committed: https://crrev.com/15e2d7bf457500773baba21cf7697bc431ad2dec Cr-Commit-Position: refs/heads/master@{#299845}

Patch Set 1 #

Patch Set 2 : Better fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
dmazzoni
6 years, 2 months ago (2014-10-15 22:22:19 UTC) #2
aelias_OOO_until_Jul13
lgtm
6 years, 2 months ago (2014-10-15 22:24:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643893003/1
6 years, 2 months ago (2014-10-15 22:27:05 UTC) #5
dmazzoni
Unchecking commit box - this isn't quite right
6 years, 2 months ago (2014-10-15 22:39:26 UTC) #7
dmazzoni
Better fix uploaded, PTAL. Sorry to waste your time.
6 years, 2 months ago (2014-10-15 22:59:06 UTC) #8
aelias_OOO_until_Jul13
lgtm
6 years, 2 months ago (2014-10-15 23:04:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643893003/20001
6 years, 2 months ago (2014-10-16 04:04:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-16 04:51:36 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 04:52:23 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/15e2d7bf457500773baba21cf7697bc431ad2dec
Cr-Commit-Position: refs/heads/master@{#299845}

Powered by Google App Engine
This is Rietveld 408576698