Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1361)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 643893003: Don't create a BrowserAccessibilityManager for a child frame on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dmazzoni_testing
Patch Set: Better fix Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index e7336e28507d7b642b2e5d92abf23f454822a89b..db406b611255e8a312adc574069adfe35cdd1e5c 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -1425,6 +1425,16 @@ void RenderWidgetHostViewAndroid::OnSetNeedsFlushInput() {
BrowserAccessibilityManager*
RenderWidgetHostViewAndroid::CreateBrowserAccessibilityManager(
BrowserAccessibilityDelegate* delegate) {
+ // TODO(dmazzoni): Currently there can only be one
+ // BrowserAccessibilityManager per ContentViewCore, so return NULL
+ // if there's already a BrowserAccessibilityManager for the main
+ // frame. Eventually, in order to support cross-process iframes on
+ // Android we'll need to add support for a
+ // BrowserAccessibilityManager for a child frame.
+ // http://crbug.com/423846
+ if (!host_ || host_->GetRootBrowserAccessibilityManager())
+ return NULL;
+
base::android::ScopedJavaLocalRef<jobject> obj;
if (content_view_core_)
obj = content_view_core_->GetJavaObject();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698