Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 643873003: DevTools: NetworkPanel: make websocket frames table "live". (Closed)

Created:
6 years, 2 months ago by eustas
Modified:
6 years, 2 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: NetworkPanel: make websocket frames table "live". 1) Fix "estimated" row height. 2) Make "time" column sortable. 3) Make table stick to bottom. 4) Add new frames as they arrive. BUG=142280 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183796

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -14 lines) Patch
M Source/devtools/front_end/network/NetworkPanel.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/network/ResourceWebSocketFrameView.js View 1 4 chunks +41 lines, -11 lines 0 comments Download
M Source/devtools/front_end/sdk/NetworkRequest.js View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eustas
6 years, 2 months ago (2014-10-16 07:59:41 UTC) #2
vsevik
lgtm https://codereview.chromium.org/643873003/diff/1/Source/devtools/front_end/network/ResourceWebSocketFrameView.js File Source/devtools/front_end/network/ResourceWebSocketFrameView.js (right): https://codereview.chromium.org/643873003/diff/1/Source/devtools/front_end/network/ResourceWebSocketFrameView.js#newcode173 Source/devtools/front_end/network/ResourceWebSocketFrameView.js:173: nodeSelfHeight: function() { { on the next line
6 years, 2 months ago (2014-10-16 08:03:32 UTC) #3
eustas
https://codereview.chromium.org/643873003/diff/1/Source/devtools/front_end/network/ResourceWebSocketFrameView.js File Source/devtools/front_end/network/ResourceWebSocketFrameView.js (right): https://codereview.chromium.org/643873003/diff/1/Source/devtools/front_end/network/ResourceWebSocketFrameView.js#newcode173 Source/devtools/front_end/network/ResourceWebSocketFrameView.js:173: nodeSelfHeight: function() { On 2014/10/16 08:03:32, vsevik wrote: > ...
6 years, 2 months ago (2014-10-16 08:32:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643873003/20001
6 years, 2 months ago (2014-10-16 08:33:18 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 09:32:47 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183796

Powered by Google App Engine
This is Rietveld 408576698