Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Unified Diff: Source/devtools/front_end/sdk/NetworkRequest.js

Issue 643873003: DevTools: NetworkPanel: make websocket frames table "live". (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/network/ResourceWebSocketFrameView.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/NetworkRequest.js
diff --git a/Source/devtools/front_end/sdk/NetworkRequest.js b/Source/devtools/front_end/sdk/NetworkRequest.js
index a86ea512fdb77c66122e4e4792cfe52878f746ba..0646fcb2cbb799fc0a19cef7bc9a682bc146804a 100644
--- a/Source/devtools/front_end/sdk/NetworkRequest.js
+++ b/Source/devtools/front_end/sdk/NetworkRequest.js
@@ -79,6 +79,7 @@ WebInspector.NetworkRequest.Events = {
RemoteAddressChanged: "RemoteAddressChanged",
RequestHeadersChanged: "RequestHeadersChanged",
ResponseHeadersChanged: "ResponseHeadersChanged",
+ WebsocketFrameAdded: "WebsocketFrameAdded",
}
/** @enum {string} */
@@ -981,7 +982,7 @@ WebInspector.NetworkRequest.prototype = {
*/
addFrameError: function(errorMessage, time)
{
- this._frames.push({ type: WebInspector.NetworkRequest.WebSocketFrameType.Error, text: errorMessage, time: time, opCode: -1, mask: false });
+ this._addFrame({ type: WebInspector.NetworkRequest.WebSocketFrameType.Error, text: errorMessage, time: time, opCode: -1, mask: false });
},
/**
@@ -992,7 +993,16 @@ WebInspector.NetworkRequest.prototype = {
addFrame: function(response, time, sent)
{
var type = sent ? WebInspector.NetworkRequest.WebSocketFrameType.Send : WebInspector.NetworkRequest.WebSocketFrameType.Receive;
- this._frames.push({ type: type, text: response.payloadData, time: time, opCode: response.opcode, mask: response.mask });
+ this._addFrame({ type: type, text: response.payloadData, time: time, opCode: response.opcode, mask: response.mask });
+ },
+
+ /**
+ * @param {!WebInspector.NetworkRequest.WebSocketFrame} frame
+ */
+ _addFrame: function(frame)
+ {
+ this._frames.push(frame);
+ this.dispatchEventToListeners(WebInspector.NetworkRequest.Events.WebsocketFrameAdded, frame);
},
__proto__: WebInspector.SDKObject.prototype
« no previous file with comments | « Source/devtools/front_end/network/ResourceWebSocketFrameView.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698