src/effects/SkLightingImageFilter.cpp - Issue 643743003: Create helper functions to use in computeInvariantOutput calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 643743003: Create helper functions to use in computeInvariantOutput calls (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fixes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkLightingImageFilter.cpp

diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp

index e78fd622a0ed2d9a52073d334cb3e6305afcb4fd..b882456234ec8b1c252be824e014da12f02bce65 100644

--- a/src/effects/SkLightingImageFilter.cpp

+++ b/src/effects/SkLightingImageFilter.cpp

@@ -355,8 +355,7 @@ protected:

virtual void onComputeInvariantOutput(InvariantOutput* inout) const SK_OVERRIDE {

// lighting shaders are complicated. We just throw up our hands.

- inout->fValidFlags = 0;

- inout->fIsSingleComponent = false;

+ inout->mulByUnknownColor();

}

private: