src/effects/SkColorMatrixFilter.cpp - Issue 643743003: Create helper functions to use in computeInvariantOutput calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkColorMatrixFilter.cpp

Issue 643743003: Create helper functions to use in computeInvariantOutput calls (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fixes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkColorMatrixFilter.cpp

diff --git a/src/effects/SkColorMatrixFilter.cpp b/src/effects/SkColorMatrixFilter.cpp

index e4d9f52aab40fd62969b8c9f44b2e3cfb1a4e36c..13d7445c1f54268305aa2441ba2bb0422364cd02 100644

--- a/src/effects/SkColorMatrixFilter.cpp

+++ b/src/effects/SkColorMatrixFilter.cpp

@@ -453,7 +453,7 @@ private:

// then we can't know the final result.

if (0 != fMatrix.fMat[kAlphaRowStartIdx + i]) {

if (!(inout->fValidFlags & kRGBAFlags[i])) {

- inout->fValidFlags = 0;

+ inout->unknownOutput();

return;

} else {

uint32_t component = (inout->fColor >> kShifts[i]) & 0xFF;