Adding openssl_bio_string to GN build.

Adding openssl_bio_string to GN build.

BUG=

Committed: https://crrev.com/b8f385c6fd01ddd2c3e47a63b822ff18ec3f1fdc
Cr-Commit-Position: refs/heads/master@{#301368}

[pwestin(chromium), 2014-10-24 22:46:31]

pwestin@chromium.org changed reviewers:
+ wtc@chromium.org

[pwestin(chromium), 2014-10-24 22:46:56]

Please review

[wtc, 2014-10-24 23:43:20]

Patch set 1 LGTM. Please make the first suggested change. The two changes
related to openssl_bio_string_unittest.cc are recommended but optional.

https://codereview.chromium.org/643703008/diff/1/crypto/BUILD.gn
File crypto/BUILD.gn (right):

https://codereview.chromium.org/643703008/diff/1/crypto/BUILD.gn#newcode53
crypto/BUILD.gn:53: "openssl_bio_string.h",

Just FYP: these two files were added in
https://codereview.chromium.org/286263006.

https://codereview.chromium.org/643703008/diff/1/crypto/BUILD.gn#newcode155
crypto/BUILD.gn:155: "hmac_openssl.cc",

IMPORTANT: Also add them here.

https://codereview.chromium.org/643703008/diff/1/crypto/BUILD.gn#newcode209
crypto/BUILD.gn:209: "nss_util_unittest.cc",

Add "openssl_bio_string_unittest.cc" here.

https://codereview.chromium.org/643703008/diff/1/crypto/BUILD.gn#newcode230
crypto/BUILD.gn:230: }

Add:

  } else {
    sources -= [ "openssl_bio_string_unittest.cc" ]
  }

[pwestin(chromium), 2014-10-24 23:51:18]

PTAL

https://codereview.chromium.org/643703008/diff/1/crypto/BUILD.gn
File crypto/BUILD.gn (right):

https://codereview.chromium.org/643703008/diff/1/crypto/BUILD.gn#newcode53
crypto/BUILD.gn:53: "openssl_bio_string.h",
On 2014/10/24 23:43:19, wtc wrote:
> 
> Just FYP: these two files were added in
> https://codereview.chromium.org/286263006.

Acknowledged.

https://codereview.chromium.org/643703008/diff/1/crypto/BUILD.gn#newcode155
crypto/BUILD.gn:155: "hmac_openssl.cc",
On 2014/10/24 23:43:19, wtc wrote:
> 
> IMPORTANT: Also add them here.

Done.

https://codereview.chromium.org/643703008/diff/1/crypto/BUILD.gn#newcode209
crypto/BUILD.gn:209: "nss_util_unittest.cc",
On 2014/10/24 23:43:19, wtc wrote:
> 
> Add "openssl_bio_string_unittest.cc" here.

Done.

https://codereview.chromium.org/643703008/diff/1/crypto/BUILD.gn#newcode230
crypto/BUILD.gn:230: }
On 2014/10/24 23:43:19, wtc wrote:
> 
> Add:
> 
>   } else {
>     sources -= [ "openssl_bio_string_unittest.cc" ]
>   }

Done.

[pwestin(chromium), 2014-10-24 23:51:37]

The CQ bit was checked by pwestin@chromium.org

[pwestin(chromium), 2014-10-24 23:51:38]

The CQ bit was unchecked by pwestin@chromium.org

[wtc, 2014-10-25 00:02:25]

Patch set 2 LGTM!

[pwestin(chromium), 2014-10-25 00:09:06]

The CQ bit was checked by pwestin@chromium.org

[commit-bot: I haz the power, 2014-10-25 00:10:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643703008/20001

[commit-bot: I haz the power, 2014-10-25 06:12:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-25 06:12:07]

Exceeded time limit waiting for builds to trigger.

[pwestin(chromium), 2014-10-27 15:00:46]

The CQ bit was checked by pwestin@chromium.org

[commit-bot: I haz the power, 2014-10-27 15:01:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643703008/20001

[commit-bot: I haz the power, 2014-10-27 15:46:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-27 15:47:44]

Patchset 2 (id:??) landed as
https://crrev.com/b8f385c6fd01ddd2c3e47a63b822ff18ec3f1fdc
Cr-Commit-Position: refs/heads/master@{#301368}