Add OpenSSL BIO method that writes to a std::string.

Add OpenSSL BIO method that writes to a std::string.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272100

[mattm, 2014-05-16 22:54:17]

Wasn't sure if this should go in crypto/ or just stick in c/common/net, wdyt?

[Ryan Sleevi, 2014-05-19 23:25:43]

I'm fine landing in crypto/

https://codereview.chromium.org/286263006/diff/40001/crypto/openssl_bio_strin...
File crypto/openssl_bio_string.cc (right):

https://codereview.chromium.org/286263006/diff/40001/crypto/openssl_bio_strin...
crypto/openssl_bio_string.cc:60: namespace crypto {
nit: I tend to like this on between lines 8-9, rather than requiring the unnamed
namespace be entirely self-constrained.

https://codereview.chromium.org/286263006/diff/40001/crypto/openssl_bio_string.h
File crypto/openssl_bio_string.h (right):

https://codereview.chromium.org/286263006/diff/40001/crypto/openssl_bio_strin...
crypto/openssl_bio_string.h:12: typedef struct bio_st BIO;
// From <openssl/bio.h>

https://codereview.chromium.org/286263006/diff/40001/crypto/openssl_bio_strin...
crypto/openssl_bio_string.h:16: BIO* CRYPTO_EXPORT BIO_new_string(std::string*
out);
Document

// Creates a new BIO that can be used with OpenSSL's
// various output functions, and which will write all output
// directly into |out|. This is primarily intended as a
// utility to reduce the amount of copying and separate
// allocations when performing extensive string modifications
// or streaming within OpenSSL.
//
// Note: |out| must remain valid for the duration of the BIO.

[mattm, 2014-05-20 00:22:24]

https://codereview.chromium.org/286263006/diff/40001/crypto/openssl_bio_strin...
File crypto/openssl_bio_string.cc (right):

https://codereview.chromium.org/286263006/diff/40001/crypto/openssl_bio_strin...
crypto/openssl_bio_string.cc:60: namespace crypto {
On 2014/05/19 23:25:44, Ryan Sleevi wrote:
> nit: I tend to like this on between lines 8-9, rather than requiring the
unnamed
> namespace be entirely self-constrained.

Done.

https://codereview.chromium.org/286263006/diff/40001/crypto/openssl_bio_string.h
File crypto/openssl_bio_string.h (right):

https://codereview.chromium.org/286263006/diff/40001/crypto/openssl_bio_strin...
crypto/openssl_bio_string.h:12: typedef struct bio_st BIO;
On 2014/05/19 23:25:44, Ryan Sleevi wrote:
> // From <openssl/bio.h>

Done.

https://codereview.chromium.org/286263006/diff/40001/crypto/openssl_bio_strin...
crypto/openssl_bio_string.h:16: BIO* CRYPTO_EXPORT BIO_new_string(std::string*
out);
On 2014/05/19 23:25:44, Ryan Sleevi wrote:
> Document
> 
> // Creates a new BIO that can be used with OpenSSL's
> // various output functions, and which will write all output
> // directly into |out|. This is primarily intended as a
> // utility to reduce the amount of copying and separate
> // allocations when performing extensive string modifications
> // or streaming within OpenSSL.
> //
> // Note: |out| must remain valid for the duration of the BIO.

Thanks, done.

[mattm, 2014-05-21 02:10:46]

ping in case you missed this one

[Ryan Sleevi, 2014-05-21 21:12:23]

lgtm

[mattm, 2014-05-21 21:13:59]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2014-05-21 21:17:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mattm@chromium.org/286263006/120001

[commit-bot: I haz the power, 2014-05-22 04:36:09]

Change committed as 272100