Issue 643673004: Revert of Fix bug in plot locking system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 643673004: Revert of Fix bug in plot locking system (Closed)

Created:
6 years, 2 months ago by robertphillips

Modified:
6 years, 2 months ago

Reviewers:
jvanverth1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Fix bug in plot locking system (patchset #3 id:80001 of https://codereview.chromium.org/640323002/) Reason for revert: Failing unit tests Original issue's description: > Fix bug in plot locking system > > In the new MultiPictureDraw tests a single hoisted layer is reused multiple times. The previous plot locking scheme allowed GrCachedLayer objects to be aggressively deleted prematurely leaving the reusing GrHoistedLayer objects with dangling pointers. > > This CL changes the plot locking system to add a pseudo-ref for each GrHoistedLayer. > > NOTRY=true > > Committed: https://skia.googlesource.com/skia/+/5c481666c9678f43e039ad605457be3854cf8de3 TBR=jvanverth@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/a32c6bce1b726b6038b97bb64daf8b1fb1eb94e0

Created: 6 years, 2 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -17 lines)			Patch
	M	src/gpu/GrLayerCache.h	View		2 chunks	+3 lines, -10 lines	0 comments	Download
	M	src/gpu/GrLayerCache.cpp	View		8 chunks	+17 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643673004/1

6 years, 2 months ago (2014-10-09 19:46:39 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-09 19:47:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as a32c6bce1b726b6038b97bb64daf8b1fb1eb94e0