components/autofill/content/renderer/password_generation_agent.h - Issue 643493003: [Password Generation] Update UMA stats for popups per page not per event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_generation_agent.h

Issue 643493003: [Password Generation] Update UMA stats for popups per page not per event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_generation_agent_browsertest.cc ('k') | components/autofill/content/renderer/password_generation_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_generation_agent.h

diff --git a/components/autofill/content/renderer/password_generation_agent.h b/components/autofill/content/renderer/password_generation_agent.h

index a2c1c12c2c517abbe9a41c8647a00c7454c887a8..ce85e7e49f7d2577e4ecc51a3aa28a9be04da15b 100644

--- a/components/autofill/content/renderer/password_generation_agent.h

+++ b/components/autofill/content/renderer/password_generation_agent.h

@@ -107,6 +107,16 @@ class PasswordGenerationAgent : public content::RenderViewObserver {

// stats.

bool password_edited_;

+ // True if the generation popup was shown during this navigation. Used to

+ // track UMA stats per page visit rather than per display, since the former

+ // is more interesting.

+ bool generation_popup_shown_;

+ // True if the editing popup was shown during this navigation. Used to track

+ // UMA stats per page rather than per display, since the former is more

+ // interesting.

+ bool editing_popup_shown_;

// If this feature is enabled. Controlled by Finch.

bool enabled_;