Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Side by Side Diff: components/autofill/content/renderer/password_generation_agent.h

Issue 643493003: [Password Generation] Update UMA stats for popups per page not per event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_AGENT_H_ 5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_AGENT_H_
6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_AGENT_H_ 6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_AGENT_H_
7 7
8 #include <map> 8 #include <map>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 blink::WebInputElement generation_element_; 100 blink::WebInputElement generation_element_;
101 101
102 // If the password field at |generation_element_| contains a generated 102 // If the password field at |generation_element_| contains a generated
103 // password. 103 // password.
104 bool password_is_generated_; 104 bool password_is_generated_;
105 105
106 // True if a password was generated and the user edited it. Used for UMA 106 // True if a password was generated and the user edited it. Used for UMA
107 // stats. 107 // stats.
108 bool password_edited_; 108 bool password_edited_;
109 109
110 // True if the generation popup was shown during this navigation. Used to
111 // track UMA stats per page visit rather than per display, since the former
112 // is more interesting.
113 bool generation_popup_shown_;
114
115 // True if the editing popup was shown during this navigation. Used to track
116 // UMA stats per page rather than per display, since the former is more
117 // interesting.
118 bool editing_popup_shown_;
119
110 // If this feature is enabled. Controlled by Finch. 120 // If this feature is enabled. Controlled by Finch.
111 bool enabled_; 121 bool enabled_;
112 122
113 DISALLOW_COPY_AND_ASSIGN(PasswordGenerationAgent); 123 DISALLOW_COPY_AND_ASSIGN(PasswordGenerationAgent);
114 }; 124 };
115 125
116 } // namespace autofill 126 } // namespace autofill
117 127
118 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_AGENT_H_ 128 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_GENERATION_AGENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698