Use UI message loop for in process GPU thread on Windows

Use UI message loop for in process GPU thread on Windows

WGL needs to create a window and should pump its message loop, so use a UI message loop.

BUG=273220
Committed: https://crrev.com/f5f241f9d0270c8e2f6eb719fad126b3621d3c86
Cr-Commit-Position: refs/heads/master@{#299395}

[jbauman, 2014-10-11 02:33:01]

jbauman@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2014-10-11 03:04:32]

There's no harm in landing this even if
https://codereview.chromium.org/649863002/ isn't landed, correct?

https://codereview.chromium.org/643373002/diff/1/content/browser/gpu/gpu_proc...
File content/browser/gpu/gpu_process_host.cc (right):

https://codereview.chromium.org/643373002/diff/1/content/browser/gpu/gpu_proc...
content/browser/gpu/gpu_process_host.cc:518: options.message_loop_type =
base::MessageLoop::TYPE_UI;
Is there any benefit to checking if --use-gl=desktop was passed, and only
setting this option if so?

[jbauman, 2014-10-11 03:30:22]

On 2014/10/11 03:04:32, Ken Russell wrote:
> There's no harm in landing this even if
> https://codereview.chromium.org/649863002/ isn't landed, correct?

Yeah, it won't cause problems.
> 
>
https://codereview.chromium.org/643373002/diff/1/content/browser/gpu/gpu_proc...
> File content/browser/gpu/gpu_process_host.cc (right):
> 
>
https://codereview.chromium.org/643373002/diff/1/content/browser/gpu/gpu_proc...
> content/browser/gpu/gpu_process_host.cc:518: options.message_loop_type =
> base::MessageLoop::TYPE_UI;
> Is there any benefit to checking if --use-gl=desktop was passed, and only
> setting this option if so?

Using TYPE_UI doesn't hurt anything (except theoretically it may make
performance slightly worse for some workloads), and we only use --in-process-gpu
on Windows for debugging, so there's not much benefit in checking that.

[Ken Russell (switch to Gerrit), 2014-10-11 17:52:08]

OK. LGTM

[jbauman, 2014-10-13 23:17:17]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2014-10-13 23:19:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643373002/1

[commit-bot: I haz the power, 2014-10-13 23:56:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-13 23:57:34]

Patchset 1 (id:??) landed as
https://crrev.com/f5f241f9d0270c8e2f6eb719fad126b3621d3c86
Cr-Commit-Position: refs/heads/master@{#299395}