Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: public/web/WebFrame.h

Issue 643333002: Prepare for remote->local frame swap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebFrame.h
diff --git a/public/web/WebFrame.h b/public/web/WebFrame.h
index 0250a19423b095f1649b85f50ec182784bb24d27..9efe81b765da7b714f7ade91dd4cea14608237ef 100644
--- a/public/web/WebFrame.h
+++ b/public/web/WebFrame.h
@@ -204,6 +204,12 @@ public:
// Removes the given child from this frame.
virtual void removeChild(WebFrame*);
+ // Sets the parent WITHOUT fulling adding it to the frame tree.
+ // Used to lie to a local frame that is replacing a remote frame,
+ // so it can properly start a navigation but wait to swap until
+ // commit-time.
+ void setParent(WebFrame*);
dcheng 2014/10/15 21:14:35 Nit: maybe call it setParentForProvisionalNavigati
Nate Chapin 2014/10/15 21:27:31 I only did it this way because m_parent is private
dcheng 2014/10/16 00:39:07 Yeah, I think making it protected would be better.
Nate Chapin 2014/10/16 21:45:56 Done.
+
// Returns the parent frame or 0 if this is a top-most frame.
BLINK_EXPORT WebFrame* parent() const;

Powered by Google App Engine
This is Rietveld 408576698