Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: public/web/WebFrame.h

Issue 643333002: Prepare for remote->local frame swap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 // Reset the frame that opened this frame to 0. 197 // Reset the frame that opened this frame to 0.
198 // This is executed between layout tests runs 198 // This is executed between layout tests runs
199 void clearOpener() { setOpener(0); } 199 void clearOpener() { setOpener(0); }
200 200
201 // Adds the given frame as a child of this frame. 201 // Adds the given frame as a child of this frame.
202 BLINK_EXPORT void appendChild(WebFrame*); 202 BLINK_EXPORT void appendChild(WebFrame*);
203 203
204 // Removes the given child from this frame. 204 // Removes the given child from this frame.
205 virtual void removeChild(WebFrame*); 205 virtual void removeChild(WebFrame*);
206 206
207 // Sets the parent WITHOUT fulling adding it to the frame tree.
208 // Used to lie to a local frame that is replacing a remote frame,
209 // so it can properly start a navigation but wait to swap until
210 // commit-time.
211 void setParent(WebFrame*);
dcheng 2014/10/15 21:14:35 Nit: maybe call it setParentForProvisionalNavigati
Nate Chapin 2014/10/15 21:27:31 I only did it this way because m_parent is private
dcheng 2014/10/16 00:39:07 Yeah, I think making it protected would be better.
Nate Chapin 2014/10/16 21:45:56 Done.
212
207 // Returns the parent frame or 0 if this is a top-most frame. 213 // Returns the parent frame or 0 if this is a top-most frame.
208 BLINK_EXPORT WebFrame* parent() const; 214 BLINK_EXPORT WebFrame* parent() const;
209 215
210 // Returns the top-most frame in the hierarchy containing this frame. 216 // Returns the top-most frame in the hierarchy containing this frame.
211 BLINK_EXPORT WebFrame* top() const; 217 BLINK_EXPORT WebFrame* top() const;
212 218
213 // Returns the first/last child frame. 219 // Returns the first/last child frame.
214 BLINK_EXPORT WebFrame* firstChild() const; 220 BLINK_EXPORT WebFrame* firstChild() const;
215 BLINK_EXPORT WebFrame* lastChild() const; 221 BLINK_EXPORT WebFrame* lastChild() const;
216 222
(...skipping 470 matching lines...) Expand 10 before | Expand all | Expand 10 after
687 WebPrivateOwnPtr<OpenedFrameTracker> m_openedFrameTracker; 693 WebPrivateOwnPtr<OpenedFrameTracker> m_openedFrameTracker;
688 }; 694 };
689 695
690 #if BLINK_IMPLEMENTATION 696 #if BLINK_IMPLEMENTATION
691 Frame* toCoreFrame(const WebFrame*); 697 Frame* toCoreFrame(const WebFrame*);
692 #endif 698 #endif
693 699
694 } // namespace blink 700 } // namespace blink
695 701
696 #endif 702 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698