Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 643283002: Add Chrome IME extensions to the whitelisted extensions for app.window.alpha (Closed)

Created:
6 years, 2 months ago by bshe
Modified:
6 years, 2 months ago
Reviewers:
Shu Chen, benwells
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add Chrome IME extensions to the whitelisted extensions for app.window.alpha This allows ime extensions creat window with proper shadow through css and a round button as in this mock: https://folio.googleplex.com/chromeinput/final/voice#%2F00%20VK_start%20to%20speak.png BUG=425539 Committed: https://crrev.com/a49d7ed44c5993dc850ab2da08e3b253f7889b7c Cr-Commit-Position: refs/heads/master@{#300697}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : add reference to crbug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/input_method/xkb_manifest.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/app_window/app_window_api.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/api/_permission_features.json View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M extensions/common/permissions/extensions_api_permissions.cc View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (5 generated)
bshe
Hello Ben. Do you mind to take a look at this CL? I know that ...
6 years, 2 months ago (2014-10-20 17:01:55 UTC) #2
benwells
On 2014/10/20 17:01:55, bshe wrote: > Hello Ben. > > Do you mind to take ...
6 years, 2 months ago (2014-10-21 04:58:19 UTC) #3
benwells
On 2014/10/21 04:58:19, benwells wrote: > On 2014/10/20 17:01:55, bshe wrote: > > Hello Ben. ...
6 years, 2 months ago (2014-10-21 05:01:29 UTC) #4
bshe
On 2014/10/21 05:01:29, benwells wrote: > On 2014/10/21 04:58:19, benwells wrote: > > On 2014/10/20 ...
6 years, 2 months ago (2014-10-21 14:28:43 UTC) #5
benwells
lgtm
6 years, 2 months ago (2014-10-22 09:22:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643283002/80001
6 years, 2 months ago (2014-10-22 13:47:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/19238)
6 years, 2 months ago (2014-10-22 13:51:27 UTC) #10
bshe
+shuchen for manifest files Thanks!
6 years, 2 months ago (2014-10-22 13:54:39 UTC) #12
Shu Chen
lgtm for ime manifests.
6 years, 2 months ago (2014-10-22 15:18:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643283002/80001
6 years, 2 months ago (2014-10-22 15:46:24 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:80001)
6 years, 2 months ago (2014-10-22 17:42:01 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 17:42:50 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a49d7ed44c5993dc850ab2da08e3b253f7889b7c
Cr-Commit-Position: refs/heads/master@{#300697}

Powered by Google App Engine
This is Rietveld 408576698