Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: extensions/browser/api/app_window/app_window_api.cc

Issue 643283002: Add Chrome IME extensions to the whitelisted extensions for app.window.alpha (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add reference to crbug Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/app_window/app_window_api.h" 5 #include "extensions/browser/api/app_window/app_window_api.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 if (options->ime.get()) { 243 if (options->ime.get()) {
244 error_ = app_window_constants::kImeOptionIsNotSupported; 244 error_ = app_window_constants::kImeOptionIsNotSupported;
245 return false; 245 return false;
246 } 246 }
247 } 247 }
248 248
249 if (options->alpha_enabled.get()) { 249 if (options->alpha_enabled.get()) {
250 const char* whitelist[] = { 250 const char* whitelist[] = {
251 #if defined(OS_CHROMEOS) 251 #if defined(OS_CHROMEOS)
252 "B58B99751225318C7EB8CF4688B5434661083E07", // http://crbug.com/410550 252 "B58B99751225318C7EB8CF4688B5434661083E07", // http://crbug.com/410550
253 "06BE211D5F014BAB34BC22D9DDA09C63A81D828E", // http://crbug.com/425539
254 "F94EE6AB36D6C6588670B2B01EB65212D9C64E33",
253 #endif 255 #endif
254 "0F42756099D914A026DADFA182871C015735DD95", // http://crbug.com/323773 256 "0F42756099D914A026DADFA182871C015735DD95", // http://crbug.com/323773
255 "2D22CDB6583FD0A13758AEBE8B15E45208B4E9A7", 257 "2D22CDB6583FD0A13758AEBE8B15E45208B4E9A7",
256 "E7E2461CE072DF036CF9592740196159E2D7C089", // http://crbug.com/356200 258 "E7E2461CE072DF036CF9592740196159E2D7C089", // http://crbug.com/356200
257 "A74A4D44C7CFCD8844830E6140C8D763E12DD8F3", 259 "A74A4D44C7CFCD8844830E6140C8D763E12DD8F3",
258 "312745D9BF916161191143F6490085EEA0434997", 260 "312745D9BF916161191143F6490085EEA0434997",
259 "53041A2FA309EECED01FFC751E7399186E860B2C", 261 "53041A2FA309EECED01FFC751E7399186E860B2C",
260 "A07A5B743CD82A1C2579DB77D353C98A23201EEF", // http://crbug.com/413748 262 "A07A5B743CD82A1C2579DB77D353C98A23201EEF", // http://crbug.com/413748
261 "F16F23C83C5F6DAD9B65A120448B34056DD80691", 263 "F16F23C83C5F6DAD9B65A120448B34056DD80691",
262 "0F585FB1D0FDFBEBCE1FEB5E9DFFB6DA476B8C9B" 264 "0F585FB1D0FDFBEBCE1FEB5E9DFFB6DA476B8C9B"
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
546 548
547 if (options.frame->as_frame_options->inactive_color.get()) { 549 if (options.frame->as_frame_options->inactive_color.get()) {
548 error_ = app_window_constants::kInactiveColorWithoutColor; 550 error_ = app_window_constants::kInactiveColorWithoutColor;
549 return false; 551 return false;
550 } 552 }
551 553
552 return true; 554 return true;
553 } 555 }
554 556
555 } // namespace extensions 557 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/resources/chromeos/input_method/xkb_manifest.json ('k') | extensions/common/api/_permission_features.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698