Source/bindings/scripts/utilities.py - Issue 643153006: IDL: Overwrite pickle file when an exception occurs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/utilities.py

Issue 643153006: IDL: Overwrite pickle file when an exception occurs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/utilities.py

diff --git a/Source/bindings/scripts/utilities.py b/Source/bindings/scripts/utilities.py

index 2cbd359087fea582e96292bfb9322045c6532096..2f5e1ed68f2a959be20a7032632aa7d9a252f341 100644

--- a/Source/bindings/scripts/utilities.py

+++ b/Source/bindings/scripts/utilities.py

@@ -116,7 +116,7 @@ def write_pickle_file(pickle_filename, data, only_if_changed):

try:

if pickle.load(pickle_file) == data:

return

- except (EOFError, pickle.UnpicklingError):

+ except (EOFError, TypeError, pickle.UnpicklingError):

Jens Widell 2014/10/24 06:32:46 Maybe just "except Exception:"? If there's somethi

# If trouble unpickling, overwrite

pass

with open(pickle_filename, 'w') as pickle_file:

« no previous file with comments | « no previous file | no next file » | no next file with comments »