IDL: Overwrite pickle file when an exception occurs

Source/bindings/scripts/utilities.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility functions (file reading, simple IDL parsing by regexes) for IDL build.
 
 Design doc: http://www.chromium.org/developers/design-documents/idl-build
 """
 
 import os
@@ skipping 98 matching lines @@
     with open(destination_filename, 'w') as destination_file:
         destination_file.write(new_text)
 
 
 def write_pickle_file(pickle_filename, data, only_if_changed):
     if only_if_changed and os.path.isfile(pickle_filename):
         with open(pickle_filename) as pickle_file:
             try:
                 if pickle.load(pickle_file) == data:
                     return
-            except (EOFError, pickle.UnpicklingError):
+            except (EOFError, TypeError, pickle.UnpicklingError):

[Jens Widell, 2014/10/24 06:32:46]

Maybe just "except Exception:"? If there's something else wrong (file
inaccessible, for instance) we'll fail below when trying to write the file
anyway.

I can't think of any reason to keep (not try to overwrite) a file we can't load.

                 # If trouble unpickling, overwrite
                 pass
     with open(pickle_filename, 'w') as pickle_file:
         pickle.dump(data, pickle_file)
 
 
 ################################################################################
 # IDL parsing
 #
 # We use regular expressions for parsing; this is incorrect (Web IDL is not a
@@ skipping 29 matching lines @@
     # FIXME: this splitting is WRONG: it fails on extended attributes where lists of
     # multiple values are used, which are seperated by a comma and a space.
     parts = [extended_attribute.strip()
              for extended_attribute in re.split(',\s+', extended_attributes_string)
              # Discard empty parts, which may exist due to trailing comma
              if extended_attribute.strip()]
     for part in parts:
         name, _, value = map(string.strip, part.partition('='))
         extended_attributes[name] = value
     return extended_attributes