IDL: Overwrite pickle file when an exception occurs

IDL: Overwrite pickle file when an exception occurs

It seems that TypeErrors can be thrown when we modify the content of
pickle files (e.g. InterfacesInfoCoreIndividual.pickle). We can
just overwrite pickle files if pickle.load() throws an exception.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184334

[bashi, 2014-10-24 06:29:12]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org

[bashi, 2014-10-24 06:29:12]

Haraken-san, PTAL?

[Jens Widell, 2014-10-24 06:32:46]

jl@opera.com changed reviewers:
+ jl@opera.com

[Jens Widell, 2014-10-24 06:32:46]

https://codereview.chromium.org/643153006/diff/1/Source/bindings/scripts/util...
File Source/bindings/scripts/utilities.py (right):

https://codereview.chromium.org/643153006/diff/1/Source/bindings/scripts/util...
Source/bindings/scripts/utilities.py:119: except (EOFError, TypeError,
pickle.UnpicklingError):
Maybe just "except Exception:"? If there's something else wrong (file
inaccessible, for instance) we'll fail below when trying to write the file
anyway.

I can't think of any reason to keep (not try to overwrite) a file we can't load.

[bashi, 2014-10-24 06:37:06]

On 2014/10/24 06:32:46, Jens Widell wrote:
>
https://codereview.chromium.org/643153006/diff/1/Source/bindings/scripts/util...
> File Source/bindings/scripts/utilities.py (right):
> 
>
https://codereview.chromium.org/643153006/diff/1/Source/bindings/scripts/util...
> Source/bindings/scripts/utilities.py:119: except (EOFError, TypeError,
> pickle.UnpicklingError):
> Maybe just "except Exception:"? If there's something else wrong (file
> inaccessible, for instance) we'll fail below when trying to write the file
> anyway.
> 
> I can't think of any reason to keep (not try to overwrite) a file we can't
load.

Makes sense. Done. Thank you for review!

[Jens Widell, 2014-10-24 06:38:00]

LGTM

[bashi, 2014-10-24 06:40:10]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2014-10-24 06:40:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643153006/20001

[haraken, 2014-10-24 07:05:42]

LGTM

[commit-bot: I haz the power, 2014-10-24 08:17:52]

Committed patchset #2 (id:20001) as 184334