Source/core/animation/AnimatableLength.h - Issue 64293008: Wrap CSS length conversion arguments in an object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/AnimatableLength.h

Issue 64293008: Wrap CSS length conversion arguments in an object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: don't make it noncopyable ; clang doesn't do the RVO stuffs? Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/animation/AnimatableLength.h

diff --git a/Source/core/animation/AnimatableLength.h b/Source/core/animation/AnimatableLength.h

index 167ff848bf0867a162c93e6f417ce3ccc964c261..a7505eb900f473501095dd50c5274ca75222a91e 100644

--- a/Source/core/animation/AnimatableLength.h

+++ b/Source/core/animation/AnimatableLength.h

@@ -73,7 +73,7 @@ public:

return adoptRef(new AnimatableLength(calcExpression, cssPrimitiveValue));

}

PassRefPtr<CSSValue> toCSSValue(NumberRange = AllValues) const;

- Length toLength(const RenderStyle* currStyle, const RenderStyle* rootStyle, double zoom, NumberRange = AllValues) const;

+ Length toLength(const CSSToLengthConversionData&, NumberRange = AllValues) const;

protected:

virtual PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue*, double fraction) const OVERRIDE;