Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl - Issue 64293008: Wrap CSS length conversion arguments in an object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

Issue 64293008: Wrap CSS length conversion arguments in an object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: don't make it noncopyable ; clang doesn't do the RVO stuffs? Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

diff --git a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

index e37d2952ef2f82076832d03688b941d4d1049b82..1acfd056a8eeadcbd89b61cd4f13aaa18e994e71 100644

--- a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

+++ b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

@@ -143,7 +143,7 @@ namespace WebCore {

state.style()->{{auto_setter}}();

else

{%- if compute_length %}

- {{ set_value(property) }}(primitiveValue->computeLength<{{property.type_name}}>(state.style(), state.rootElementStyle(), state.style()->effectiveZoom()));

+ {{ set_value(property) }}(primitiveValue->computeLength<{{property.type_name}}>(state.cssToLengthConversionData()));

{%- else %}

{{ set_value(property) }}(*primitiveValue);

{%- endif %}

« no previous file with comments | « no previous file | Source/core/animation/AnimatableLength.h » ('j') | no next file with comments »