Throw IllegalArgumentException from addQuicHint if host is URL.

Throw IllegalArgumentException from Cronet HttpUrlRequestFactoryConfig.addQuicHint if host param is URL.

This is needed to prevent invalid hosts from being added to HttpServerProperties and having Quic hints not working correctly.

HttpUrlRequestFactoryConfig is pure Java and doesn't depend on native library, so it only provides a rudimentary check, but URLRequestContextAdapter::InitRequestContextOnNetworkThread() performs IsCanonicalizedHostCompliant check and uses LOG(ERROR) for invalid hosts.

BUG=420464
TEST=build/android/test_runner.py instrumentation  --test-apk=CronetTestInstrumentation -f *Quic*

Committed: https://crrev.com/f937604c661f75a423b6e1c0a285eff9a8556577
Cr-Commit-Position: refs/heads/master@{#300363}

[mef, 2014-10-20 16:24:59]

mef@chromium.org changed reviewers:
+ mmenke@chromium.org, xunjieli@chromium.org

[mef, 2014-10-20 16:25:13]

Hi, please take a look.

[xunjieli, 2014-10-20 16:39:19]

lgtm with nits

https://codereview.chromium.org/642913004/diff/1/components/cronet/android/ja...
File
components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactoryConfig.java
(right):

https://codereview.chromium.org/642913004/diff/1/components/cronet/android/ja...
components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactoryConfig.java:107:
* @param host of the server that supports QUIC.
May add a phrase here saying that the host string should not contain the scheme
or in the exception message string to make it clear?

[mmenke, 2014-10-20 17:13:46]

Should we do a more thorough test, to protect people from shooting themselves in
the foot?  Thinking something like: "!ParseIPLiteralToNumber(url, ..) &&
!IsCanonicalizedHostCompliant(CanonicalizeHost(url))", though it's a bit more
expensive.

Something I hadn't considered:  Sure the hosts in the list be canonicalized
before being added?  I'm not sure if we end up canonicalizing server names
before we make it to the server properties, but I wouldn't be surprised if we
do.

[mef, 2014-10-20 19:20:01]

Thanks! Per offline discussion HttpUrlRequestFactoryConfig is pure Java and
doesn't depend on native library, so it only provides a rudimentary check, but
I've added IsCanonicalizedHostCompliant check to
URLRequestContextAdapter::InitRequestContextOnNetworkThread().

[mmenke, 2014-10-20 19:45:07]

On 2014/10/20 19:20:01, mef wrote:
> Thanks! Per offline discussion HttpUrlRequestFactoryConfig is pure Java and
> doesn't depend on native library, so it only provides a rudimentary check, but
> I've added IsCanonicalizedHostCompliant check to
> URLRequestContextAdapter::InitRequestContextOnNetworkThread().

LGTM

[mef, 2014-10-20 20:11:39]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2014-10-20 20:12:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/642913004/20001

[commit-bot: I haz the power, 2014-10-20 22:11:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-20 22:11:22]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[mef, 2014-10-20 22:28:17]

The CQ bit was checked by mef@chromium.org

[commit-bot: I haz the power, 2014-10-20 22:30:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/642913004/20001

[commit-bot: I haz the power, 2014-10-20 22:42:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-20 22:43:37]

Patchset 2 (id:??) landed as
https://crrev.com/f937604c661f75a423b6e1c0a285eff9a8556577
Cr-Commit-Position: refs/heads/master@{#300363}