components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HttpUrlRequestFactoryTest.java - Issue 642913004: Throw IllegalArgumentException from addQuicHint if host is URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HttpUrlRequestFactoryTest.java

Issue 642913004: Throw IllegalArgumentException from addQuicHint if host is URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add IsCanonicalizedHostCompliant check to Quic Hint parsing. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactoryConfig.java ('k') | components/cronet/android/url_request_context_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HttpUrlRequestFactoryTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HttpUrlRequestFactoryTest.java b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HttpUrlRequestFactoryTest.java

index 52b9171e47cabea20d7e6d874ecb0c21be5cac35..eae50c2c075786e7ad3654383c3da1a1e709b562 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HttpUrlRequestFactoryTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/HttpUrlRequestFactoryTest.java

@@ -58,4 +58,17 @@ public class HttpUrlRequestFactoryTest extends CronetTestBase {

"HttpUrlConnection/\\d+\\.\\d+\\.\\d+\\.\\d+@\\w+",

factory.getName()));

}

+ @SmallTest

+ @Feature({"Cronet"})

+ public void testQuicHintHost() {

+ HttpUrlRequestFactoryConfig config = new HttpUrlRequestFactoryConfig();

+ config.addQuicHint("www.google.com", 443, 443);

+ try {

+ config.addQuicHint("https://www.google.com", 443, 443);

+ } catch (IllegalArgumentException e) {

+ return;

+ }

+ fail("IllegalArgumentException must be thrown");

+ }

}