Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: third_party/android_platform/development/scripts/stack

Issue 642843003: Revert of Make it easier to debug failed symbolization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-crazy-linker
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/android_platform/development/scripts/stack
diff --git a/third_party/android_platform/development/scripts/stack b/third_party/android_platform/development/scripts/stack
index 5a7d2f4d8953520635d47a430b9ae0a4e0ea0a78..e55f688ed4ed4ccde0ed3bfd33b7733aac87d7b2 100755
--- a/third_party/android_platform/development/scripts/stack
+++ b/third_party/android_platform/development/scripts/stack
@@ -18,7 +18,6 @@
import getopt
import glob
-import logging
import os
import sys
@@ -57,9 +56,6 @@
print
print " --arch=arm|arm64|x86_64|x86|mips"
print " the target architecture"
- print
- print " --verbose"
- print " enable extra logging, particularly for debugging failed symbolization"
print
print " FILE should contain a stack trace in it somewhere"
print " the tool will find that and re-print it with"
@@ -112,16 +108,15 @@
return (symdir, symdir)
-def main(argv):
+def main():
try:
- options, arguments = getopt.getopt(argv, "",
+ options, arguments = getopt.getopt(sys.argv[1:], "",
["more-info",
"less-info",
"chrome-symbols-dir=",
"symbols-dir=",
"symbols-zip=",
"arch=",
- "verbose",
"help"])
except getopt.GetoptError, unused_error:
PrintUsage()
@@ -143,8 +138,6 @@
more_info = True
elif option == "--less-info":
more_info = False
- elif option == "--verbose":
- logging.basicConfig(level=logging.DEBUG)
if len(arguments) > 1:
PrintUsage()
@@ -174,6 +167,6 @@
os.system(cmd)
if __name__ == "__main__":
- sys.exit(main(sys.argv[1:]))
+ main()
# vi: ts=2 sw=2
« no previous file with comments | « third_party/android_platform/README.chromium ('k') | third_party/android_platform/development/scripts/stack_core.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698