third_party/android_platform/development/scripts/stack_core.py - Issue 642843003: Revert of Make it easier to debug failed symbolization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/android_platform/development/scripts/stack_core.py

Issue 642843003: Revert of Make it easier to debug failed symbolization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-crazy-linker

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/android_platform/development/scripts/stack ('k') | third_party/android_platform/development/scripts/symbol.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/android_platform/development/scripts/stack_core.py

diff --git a/third_party/android_platform/development/scripts/stack_core.py b/third_party/android_platform/development/scripts/stack_core.py

index adb254b163fea30a4a3313035cb0568509fc8568..a11fbb4cf97f4a96693d4ff678689e7a14214fb0 100755

--- a/third_party/android_platform/development/scripts/stack_core.py

+++ b/third_party/android_platform/development/scripts/stack_core.py

@@ -16,7 +16,6 @@

"""stack symbolizes native crash dumps."""

-import logging

import re

import symbol

@@ -193,7 +192,6 @@

if match:

frame, code_addr, area, symbol_present, symbol_name = match.group(

'frame', 'address', 'lib', 'symbol_present', 'symbol_name')

- logging.debug('Found trace line: %s' % line.strip())

if frame <= last_frame and (trace_lines or value_lines):

PrintOutput(trace_lines, value_lines, more_info)

@@ -205,11 +203,9 @@

if area == UNKNOWN or area == HEAP or area == STACK:

trace_lines.append((code_addr, "", area))

else:

- logging.debug('Identified lib: %s' % area)

# If a calls b which further calls c and c is inlined to b, we want to

# display "a -> b -> c" in the stack trace instead of just "a -> c"

info = symbol.SymbolInformation(area, code_addr, more_info)

- logging.debug('symbol information: %s' % info)

nest_count = len(info) - 1

for (source_symbol, source_location, object_symbol_with_offset) in info:

if not source_symbol: