Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 642843003: Revert of Make it easier to debug failed symbolization (Closed)

Created:
6 years, 2 months ago by maniscalco
Modified:
6 years, 2 months ago
Reviewers:
cjhopman, rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-crazy-linker
Project:
chromium
Visibility:
Public.

Description

Revert of Make it easier to debug failed symbolization (patchset #4 id:130001 of https://codereview.chromium.org/646683002/) Reason for revert: "Android Tests" bot is failing in "run stack tool with logcat dump" step. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests Suspecting this patch. Reverting. @@@BUILD_STEP Run stack tool with logcat dump@@@ > /b/build/slave/Android_Tests/build/src/third_party/android_platform/development/scripts/stack --more-info /b/build/slave/Android_Tests/build/src/out/Release/full_log.txt /b/build/slave/Android_Tests/build/src/third_party/android_platform/development/scripts/../../../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/arm-linux-androideabi-addr2line: /b/build/slave/Android_Tests/build/src/third_party/android_platform/development/scripts/../../../../out/Release/icudtl.dat: File format not recognized See bug https://code.google.com/p/chromium/issues/detail?id=422090 Original issue's description: > Make it easier to debug failed symbolization > > This just adds a --verbose argument and some debug logging sprinkled in > useful places. > > Adds '.' as a candidate directory for libraries (gn puts shared > libraries at the root build directory). > > Committed: https://crrev.com/17ffc51dfc9bd6dfe0d38ce8f6f8313544ea25af > Cr-Commit-Position: refs/heads/master@{#298952} TBR=rmcilroy@chromium.org,cjhopman@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/46fa7a44fb117ffb4f60aca184e9860bb4111e29 Cr-Commit-Position: refs/heads/master@{#299002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -27 lines) Patch
M third_party/android_platform/README.chromium View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/android_platform/development/scripts/stack View 5 chunks +3 lines, -10 lines 0 comments Download
M third_party/android_platform/development/scripts/stack_core.py View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/android_platform/development/scripts/symbol.py View 4 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
maniscalco
Created Revert of Make it easier to debug failed symbolization
6 years, 2 months ago (2014-10-09 22:51:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642843003/1
6 years, 2 months ago (2014-10-09 22:53:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 22:55:18 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 22:55:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46fa7a44fb117ffb4f60aca184e9860bb4111e29
Cr-Commit-Position: refs/heads/master@{#299002}

Powered by Google App Engine
This is Rietveld 408576698