Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 642823006: Move forwardInputEvent to RemoteFrameClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix review comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | Source/web/RemoteFrameClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ChromeClientImpl.cpp
diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp
index 6017435c6e38b4754c6e11d72c9ce4e091c77742..e00c467aa26038b1647c22d237ca35bd31a560e5 100644
--- a/Source/web/ChromeClientImpl.cpp
+++ b/Source/web/ChromeClientImpl.cpp
@@ -39,13 +39,8 @@
#include "core/dom/Document.h"
#include "core/dom/Fullscreen.h"
#include "core/dom/Node.h"
-#include "core/events/KeyboardEvent.h"
-#include "core/events/MouseEvent.h"
-#include "core/events/WheelEvent.h"
#include "core/frame/Console.h"
#include "core/frame/FrameView.h"
-#include "core/frame/RemoteFrame.h"
-#include "core/frame/RemoteFrameView.h"
#include "core/frame/Settings.h"
#include "core/html/HTMLInputElement.h"
#include "core/html/forms/ColorChooser.h"
@@ -103,7 +98,6 @@
#include "web/WebLocalFrameImpl.h"
#include "web/WebPluginContainerImpl.h"
#include "web/WebPopupMenuImpl.h"
-#include "web/WebRemoteFrameImpl.h"
#include "web/WebSettingsImpl.h"
#include "web/WebViewImpl.h"
#include "wtf/text/CString.h"
@@ -843,33 +837,6 @@ void ChromeClientImpl::handleKeyboardEventOnTextField(HTMLInputElement& inputEle
m_webView->autofillClient()->textFieldDidReceiveKeyDown(WebInputElement(&inputElement), WebKeyboardEventBuilder(event));
}
-// FIXME: Remove this code once we have input routing in the browser
-// process. See http://crbug.com/339659.
-void ChromeClientImpl::forwardInputEvent(
- RemoteFrame* frame, Event* event)
-{
- WebRemoteFrameImpl* webFrame = WebRemoteFrameImpl::fromFrame(*frame);
-
- // This is only called when we have out-of-process iframes, which
- // need to forward input events across processes.
- // FIXME: Add a check for out-of-process iframes enabled.
- if (event->isKeyboardEvent()) {
- WebKeyboardEventBuilder webEvent(*static_cast<KeyboardEvent*>(event));
- webFrame->client()->forwardInputEvent(&webEvent);
- } else if (event->isMouseEvent()) {
- WebMouseEventBuilder webEvent(webFrame->frame()->view(), frame->ownerRenderer(), *static_cast<MouseEvent*>(event));
- // Internal Blink events should not be forwarded.
- if (webEvent.type == WebInputEvent::Undefined)
- return;
- webFrame->client()->forwardInputEvent(&webEvent);
- } else if (event->isWheelEvent()) {
- WebMouseWheelEventBuilder webEvent(webFrame->frame()->view(), frame->ownerRenderer(), *static_cast<WheelEvent*>(event));
- if (webEvent.type == WebInputEvent::Undefined)
- return;
- webFrame->client()->forwardInputEvent(&webEvent);
- }
-}
-
void ChromeClientImpl::didChangeValueInTextField(HTMLFormControlElement& element)
{
if (!m_webView->autofillClient())
« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | Source/web/RemoteFrameClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698