Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 642633004: Don't call expensive toString() in onAccessibilityEvent (Closed)

Created:
6 years, 2 months ago by aboxhall
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't call expensive toString() in onAccessibilityEvent BUG=309681 Committed: https://crrev.com/6e097e240fcd4415dc7fdb03d56c7c80e920d642 Cr-Commit-Position: refs/heads/master@{#299732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
aboxhall
6 years, 2 months ago (2014-10-15 17:06:00 UTC) #2
David Tseng
lgtm
6 years, 2 months ago (2014-10-15 17:13:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642633004/1
6 years, 2 months ago (2014-10-15 17:48:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 18:56:55 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 18:57:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e097e240fcd4415dc7fdb03d56c7c80e920d642
Cr-Commit-Position: refs/heads/master@{#299732}

Powered by Google App Engine
This is Rietveld 408576698