chrome/renderer/resources/extensions/automation/automation_node.js - Issue 642633004: Don't call expensive toString() in onAccessibilityEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/automation/automation_node.js

Issue 642633004: Don't call expensive toString() in onAccessibilityEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/resources/extensions/automation/automation_node.js

diff --git a/chrome/renderer/resources/extensions/automation/automation_node.js b/chrome/renderer/resources/extensions/automation/automation_node.js

index e232813016d58b14b380f1dd278162a2c986b3c5..fb851690585913880b3ba70de3c1a2f1ea4dbd09 100644

--- a/chrome/renderer/resources/extensions/automation/automation_node.js

+++ b/chrome/renderer/resources/extensions/automation/automation_node.js

@@ -368,7 +368,7 @@ AutomationRootNodeImpl.prototype = {

} else {

logging.WARNING('Got ' + eventParams.eventType +

' event on unknown node: ' + eventParams.targetID +

- '; this: ' + this.toString());

+ '; this: ' + this.id);

}

return true;

« no previous file with comments | « no previous file | no next file » | no next file with comments »