Issue 64243002: Restore old behavior where "Sans" was used as fallback font

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 64243002: Restore old behavior where "Sans" was used as fallback font (Closed)

Created:
7 years, 1 month ago by fs

Modified:
7 years, 1 month ago

Reviewers:
jochen (gone - plz use gerrit), eae, eseidel

CC:
blink-reviews, Paweł Hajdan Jr., rogerj

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Restore old behavior where "Sans" was used as fallback font https://codereview.chromium.org/31923005 changed the fallback font logic, it was probably not intended since it merely moved code around. This restores the logic so that "Sans" is always tried when looking for a fallback family. SkFontConfigInterface_direct.cpp looks for fallbacks among all available fonts iff "Sans", "Serif", "Monospace" or "" is requested. So it's important that at least one of those is tried. This avoids crashing the renderer process if "Arial" is missing on the system. BUG=309714 AUTHOR=rogerj@opera.com TBR=eae@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161534