Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 31923005: Move Alternate Family Logic into separate header (Closed)

Created:
7 years, 2 months ago by eae
Modified:
7 years, 2 months ago
Reviewers:
eseidel
CC:
blink-reviews, jamesr, dsinclair, danakj, Rik, Stephen Chennney, pdr.
Visibility:
Public.

Description

Move Alternate Family Logic into separate header Move the alternate font family name logic out of FontCache and into a new dedicated AlternateFontFamily.h file. This moves the non-cache related functionality out of the FontCache simplifying the interface. BUG=309714 R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160163

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -94 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A Source/core/platform/graphics/AlternateFontFamily.h View 1 1 chunk +128 lines, -0 lines 0 comments Download
M Source/core/platform/graphics/FontCache.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/FontCache.cpp View 3 chunks +2 lines, -91 lines 0 comments Download
M Source/core/platform/graphics/skia/FontCacheSkia.cpp View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eae
7 years, 2 months ago (2013-10-21 18:10:03 UTC) #1
eseidel
lgtm
7 years, 2 months ago (2013-10-21 18:16:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/31923005/1
7 years, 2 months ago (2013-10-21 18:17:48 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-21 18:51:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/31923005/170001
7 years, 2 months ago (2013-10-21 19:56:57 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 09:11:00 UTC) #6
Message was sent while issue was closed.
Change committed as 160163

Powered by Google App Engine
This is Rietveld 408576698