Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 642343003: gfx: De-templatize the gfx::Point and gfx::PointF classes. (Closed)

Created:
6 years, 2 months ago by danakj
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, enne (OOO), oshima_chomium.org, piman, clholgat, Peter Kasting
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

gfx: De-templatize the gfx::Point and gfx::PointF classes. This shrinks the android ChromeShell APK by 600 bytes, and improves performance on compositor benchmarks. Numbers can be found here https://crbug.com/407444#c15 but the summary is this saves about 0.1ms cpu time on the JS_FULL_SCREEN_INVALIDATION test in the thread_times.tough_compositor_cases test suite. This also makes it easier to read and find functions in the Point and PointF classes for developers. R=sky BUG=407444 Committed: https://crrev.com/76b13bfe17a7bf70ea6a2763e1f8c68aca794f66 Cr-Commit-Position: refs/heads/master@{#300283}

Patch Set 1 : inlines-point: gn #

Patch Set 2 : inlines-point: header-in-tests #

Patch Set 3 : inlines-point: windows #

Patch Set 4 : inlines-point: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -124 lines) Patch
M ui/gfx/geometry/BUILD.gn View 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/geometry/point.h View 1 2 5 chunks +51 lines, -10 lines 0 comments Download
M ui/gfx/geometry/point.cc View 1 2 2 chunks +14 lines, -15 lines 0 comments Download
D ui/gfx/geometry/point_base.h View 1 chunk +0 lines, -87 lines 0 comments Download
M ui/gfx/geometry/point_f.h View 3 chunks +49 lines, -8 lines 0 comments Download
M ui/gfx/geometry/point_f.cc View 1 chunk +9 lines, -1 line 0 comments Download
M ui/gfx/geometry/point_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/gfx.gyp View 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
danakj
6 years, 2 months ago (2014-10-18 17:57:02 UTC) #5
sky
LGTM
6 years, 2 months ago (2014-10-20 16:40:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642343003/140001
6 years, 2 months ago (2014-10-20 16:42:11 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:140001)
6 years, 2 months ago (2014-10-20 17:08:11 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 17:09:13 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/76b13bfe17a7bf70ea6a2763e1f8c68aca794f66
Cr-Commit-Position: refs/heads/master@{#300283}

Powered by Google App Engine
This is Rietveld 408576698