Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 642323002: Extending support for 3d in gfx::InterpolatedScale and gfx::InterpolatedTranslation (Closed)

Created:
6 years, 2 months ago by patro
Modified:
6 years, 2 months ago
Reviewers:
Ian Vollick, Sikugu_
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Extending support for 3d in gfx::InterpolatedScale and gfx::InterpolatedTranslation Previously InterpolatedScale and InterpolatedTranslation supported only 2d Translate and 2d Scale. Added support for 3d Translate and Scale. Committed: https://crrev.com/e8966b432e46bdae10cdcec4e396317176992132 Cr-Commit-Position: refs/heads/master@{#299258}

Patch Set 1 #

Patch Set 2 : Adding unit_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -8 lines) Patch
M ui/gfx/interpolated_transform.h View 1 chunk +8 lines, -2 lines 0 comments Download
M ui/gfx/interpolated_transform.cc View 2 chunks +19 lines, -5 lines 0 comments Download
M ui/gfx/interpolated_transform_unittest.cc View 1 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
patro
Kindly Review Thanks, Shyam Patro
6 years, 2 months ago (2014-10-10 14:38:49 UTC) #2
Ian Vollick
On 2014/10/10 at 14:38:49, behara.ms wrote: > Kindly Review > > Thanks, > Shyam Patro ...
6 years, 2 months ago (2014-10-10 15:04:17 UTC) #3
patro
Added unit_tests Please review Thanks, Shyam Patro
6 years, 2 months ago (2014-10-11 06:34:52 UTC) #4
Ian Vollick
On 2014/10/11 at 06:34:52, behara.ms wrote: > Added unit_tests > > Please review > > ...
6 years, 2 months ago (2014-10-12 13:19:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642323002/70001
6 years, 2 months ago (2014-10-12 13:20:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/24953)
6 years, 2 months ago (2014-10-12 14:48:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/642323002/70001
6 years, 2 months ago (2014-10-12 17:44:19 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:70001)
6 years, 2 months ago (2014-10-12 18:22:17 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-12 18:22:59 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e8966b432e46bdae10cdcec4e396317176992132
Cr-Commit-Position: refs/heads/master@{#299258}

Powered by Google App Engine
This is Rietveld 408576698