[C++11 Allowed Features] Declares a type-safe null pointer converting from NULL to nullptr

[C++11 Allowed Features] Declares a type-safe null pointer converting from NULL to  nullptr

BUG =

[pruthvi.m, 2014-10-10 13:45:21]

pruthvi.m@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[pruthvi.m, 2014-10-10 13:45:21]

Please review.
My CLA is in process, will update the comments once it is done.

Thank You.

[dmazzoni, 2014-10-10 16:49:49]

https://codereview.chromium.org/642313003/diff/220001/content/browser/accessi...
File content/browser/accessibility/accessibility_mode_browsertest.cc (right):

https://codereview.chromium.org/642313003/diff/220001/content/browser/accessi...
content/browser/accessibility/accessibility_mode_browsertest.cc:36:
(BrowserAccessibilityManager*)nullptr,
Is the typecast still necessary when we use nullptr? I expect it isn't. Please
try removing the typecast whenever NULL was used inside an EXPECT or ASSERT
assertion in a test.

https://codereview.chromium.org/642313003/diff/220001/content/browser/accessi...
File content/browser/accessibility/accessibility_win_browsertest.cc (right):

https://codereview.chromium.org/642313003/diff/220001/content/browser/accessi...
content/browser/accessibility/accessibility_win_browsertest.cc:597:
ASSERT_NE(document_accessible.get(), reinterpret_cast<IAccessible*>(nullptr));
same here, shouldn't be necessary to cast - let's try without and make sure it
compiles everywhere

[Avi (use Gerrit), 2014-10-10 16:54:43]

Your change description makes no sense. "[C++11 Allowed Features] Declares a
type-safe null pointer converting from NULL to  nullptr". This change does not
declare any pointers. This description seems to mash together two sentences:
"C++11 declares a type safe null pointer" and "This change converts from NULL to
nullptr". Please rewrite it to be grammatical English.

Also, if we’re doing a bulk conversion from NULL to nullptr, we should have a
master BUG tying this all together.

[Avi (use Gerrit), 2014-10-10 21:17:00]

On 2014/10/10 16:54:43, Avi wrote:
> Your change description makes no sense. "[C++11 Allowed Features] Declares a
> type-safe null pointer converting from NULL to  nullptr". This change does not
> declare any pointers. This description seems to mash together two sentences:
> "C++11 declares a type safe null pointer" and "This change converts from NULL
to
> nullptr". Please rewrite it to be grammatical English.
> 
> Also, if we’re doing a bulk conversion from NULL to nullptr, we should have a
> master BUG tying this all together.

Peter wrote up a guideline as to doing these kinds of changes:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/As26W6SbxQU

[dmazzoni, 2014-10-21 18:44:50]

dmazzoni@chromium.org changed reviewers:
- dmazzoni@chromium.org

[Avi (use Gerrit), 2014-10-24 21:08:17]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[pruthvi.m, 2015-06-10 14:42:22]

I am Sorry for the delayed response.
Just started with opensource contribution.
It seems that it is not good to make these trivial changes, so closing it.

Thank you.